build: conditionally compile bundled sqlite #55409
Open
+0
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
added
build
|
Review requested:
|
Only compile the bundled sqlite in `deps/sqlite` if Node.js was not configured with `--shared-sqlite`. `node.gypi` is already correctly adding the sqlite dependency if `node_shared_sqlite=="false"` so the unconditional entries in `node.gyp` are not necessary.
richardlau
added
dont-land-on-v18.x
lpinca
approved these changes
Oct 16, 2024
github-actions
bot
removed
the
request-ci
RedYetiDev
added
the
author ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only compile the bundled sqlite in
deps/sqliteif Node.js was not configured with--shared-sqlite.node.gypiis already correctly adding the sqlite dependency ifnode_shared_sqlite=="false"so the unconditional entries innode.gypare not necessary.It looks like there are other dependencies that would need a similar change, but I'm not including those here because the sqlite dependency is much easier to check (deleting the
deps/sqlitedirectory and linking against (with--shared-sqlite)libsqlite3-devon Ubuntu orsqlite-develon Fedora).